fix: prevent default on escape key presses #16202
Conversation
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
jelbourn,
josephperrott and
mmalerba
as code owners
googlebot
added
the
cla: yes
|
LGTM, should be fine to leave them all in one PR as long as the presubmit goes ok |
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
@crisbeto looks like we have a test in tooltip that needs to be udpated for this change |
crisbeto
force-pushed
the
16105/escape-prevent-default
branch
from
e36b43a to
37024bf
Compare
|
Sorted out the test failure. |
Adds a `preventDefault` to the escape key presses of the popover edit and ignores escape presses that have a modifier key. This prevents Safari from exiting fullscreen mode and avoids interfering with other OS-level actions. We already made a pass to add this logic to all other overlay components in angular#16202, but it looks like we missed the popover edit.
Adds a `preventDefault` to the escape key presses of the popover edit and ignores escape presses that have a modifier key. This prevents Safari from exiting fullscreen mode and avoids interfering with other OS-level actions. We already made a pass to add this logic to all other overlay components in #16202, but it looks like we missed the popover edit.
Adds a `preventDefault` to the escape key presses of the popover edit and ignores escape presses that have a modifier key. This prevents Safari from exiting fullscreen mode and avoids interfering with other OS-level actions. We already made a pass to add this logic to all other overlay components in #16202, but it looks like we missed the popover edit. (cherry picked from commit 48cc514)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Calls
preventDefaulton all handlers that deal with the escape key, except when a modifier is pressed since the user might've intended something different. We need to prevent the default action, because Safari will exit fullscreen mode if the user has it enabled and we want to prevent any other OS-level actions.I've split this into one commit per component as we've discussed, but I can separate them into different PRs if necessary.
Fixes #16105.