-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: release-staging script should have option to not bump version #16147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: release-staging script should have option to not bump version #16147
Conversation
Adds a new prompt choice when staging a new release that can be used if the version has been updated before. In that case we don't want to bump the version automatically but rather use the existing version and generate the changelog for it. Closes angular#16136
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
this.major, this.minor, this.patch, this.prereleaseLabel, this.prereleaseNumber); | ||
} | ||
|
||
equalsTo(other: Version): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just equals
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh just saw this. I'm fine going with equals
. Will update this as part of a follow-up PR that touches the release tools 👍
…ngular#16147) Adds a new prompt choice when staging a new release that can be used if the version has been updated before. In that case we don't want to bump the version automatically but rather use the existing version and generate the changelog for it. Closes angular#16136
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds a new prompt choice when staging a new release that can
be used if the version has been updated before. In that case we
don't want to bump the version automatically but rather use the
existing version and generate the changelog for it.
Closes #16136