fix(popover-edit): rework host listeners to account for changes in Ivy #16060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches all of the inherited event listeners in `popover-edit` to use `@HostListener`. In Ivy the `host` objects are merged when inheriting, whereas in ViewEngine they are overwritten. This means that with the current setup we'll end up with double event listeners once Ivy lands.
crisbeto
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
|
Another approach to consider here is pulling the common functionality into non-directive abstract classes and having both the Cdk and Mat versions derive from the abstract class rather than the current approach of Mat deriving from Cdk. |
|
I don't think that would make much of a difference. I'd rather keep it like this since it's consistent with what we did on other components. We can clean it up once Ivy is default. |
jelbourn
added
pr: lgtm
action: merge
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
angular#16060) Switches all of the inherited event listeners in `popover-edit` to use `@HostListener`. In Ivy the `host` objects are merged when inheriting, whereas in ViewEngine they are overwritten. This means that with the current setup we'll end up with double event listeners once Ivy lands.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches all of the inherited event listeners in
popover-editto use@HostListener. In Ivy thehostobjects are merged when inheriting, whereas in ViewEngine they are overwritten. This means that with the current setup we'll end up with double event listeners once Ivy lands.