fix(button): avoid direct access to nativeElement for consistency #16056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
May 20, 2019
src/material/button/button.ts
Outdated
| @@ -98,7 +98,7 @@ export class MatButton extends _MatButtonMixinBase | |||
| // attributes, add the correct corresponding class. | |||
| for (const attr of BUTTON_HOST_ATTRIBUTES) { | |||
| if (this._hasHostAttributes(attr)) { | |||
| (elementRef.nativeElement as HTMLElement).classList.add(attr); | |||
| this._getHostElement().classList.add(attr); | |||
There was a problem hiding this comment.
Could you also add a return type of HTMLElement to _getHostElement in this PR? That will ensure that the type safety remains
codef0rmer
force-pushed
the
fix/button-native-el-reference
branch
from
57ae009 to
facdaf5
Compare
jelbourn
added
pr: lgtm
action: merge
|
Commit message should be: |
codef0rmer
force-pushed
the
fix/button-native-el-reference
branch
from
facdaf5 to
6edd0d3
Compare
|
Done. |
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
andrewseguin
pushed a commit
that referenced
this pull request
Jul 2, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.