Skip to content

refactor(drag-drop): add current index to entered event #15932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2019
Merged

refactor(drag-drop): add current index to entered event #15932

merged 1 commit into from
May 13, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 1, 2019

Adds the index at which the item entered a new container to the entered events.

Fixes #15924.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label May 1, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 1, 2019
@crisbeto crisbeto force-pushed the 15924/enter-event-index branch from d1660c1 to 3ac6abc Compare May 1, 2019 17:18
@crisbeto
refactor(drag-drop): add current index to entered event
3ac6abc 
Adds the index at which the item entered a new container to the `entered` events.

Fixes angular#15924.
jelbourn
jelbourn approved these changes May 1, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 1, 2019
@jelbourn jelbourn merged commit fc0b971 into angular:master May 13, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@crisbeto @RudolfFrederiksen
refactor(drag-drop): add current index to entered event (angular#15932)
ccfe0c6 
Adds the index at which the item entered a new container to the `entered` events.

Fixes angular#15924.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@vuonghungvinh vuonghungvinh vuonghungvinh approved these changes

@pacificsoftdevpt pacificsoftdevpt pacificsoftdevpt approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get currentIndex of item in drop container of event cdkDropListEntered
5 participants
@crisbeto @jelbourn @vuonghungvinh @pacificsoftdevpt @googlebot