Skip to content

refactor(sidenav): expose api to update content margins #15833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2019

Conversation

crisbeto
Copy link
Member

Exposes an API so that consumers can trigger an update of the content margins manually. This allows the sidenav to handle some cases that might not have accounted for.

Fixes #15777.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Apr 16, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner April 16, 2019 14:45
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 16, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 16, 2019
Copy link
Contributor

@Airblader Airblader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on my comment about using cdkObserveContent? At least we could add it to the documentation as an alternative to autosize.

Exposes an API so that consumers can trigger an update of the content margins manually. This allows the sidenav to handle some cases that might not have accounted for.

Fixes angular#15777.
@crisbeto crisbeto force-pushed the 15777/sidenav-update-margins-api branch from 60d45b9 to e0d8260 Compare April 25, 2019 21:10
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@jelbourn jelbourn merged commit b5889ca into angular:master May 14, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
Exposes an API so that consumers can trigger an update of the content margins manually. This allows the sidenav to handle some cases that might not have accounted for.

Fixes angular#15777.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deliberately and manually trigger resize of drawer / sidenav
5 participants