fix(icon): handle unescaped characters in names #15678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Apr 1, 2019
src/lib/icon/icon-registry.ts
Outdated
| @@ -449,7 +449,7 @@ export class MatIconRegistry implements OnDestroy { | |||
| * returns it. Returns null if no matching element is found. | |||
| */ | |||
| private _extractSvgIconFromSet(iconSet: SVGElement, iconName: string): SVGElement | null { | |||
| const iconSource = iconSet.querySelector('#' + iconName); | |||
| const iconSource = iconSet.querySelector(`[id="${iconName}"]`); | |||
There was a problem hiding this comment.
Could you add a comment here like
// Use the `id="xxx"` syntax in order to escape special characters in the ID
// (versus using the #xxx syntax) 
crisbeto
force-pushed
the
15673/icon-unescaped-characters
branch
from
1752fa4 to
8ec5964
Compare
|
@crisbeto this passes presubmit, just needs a rebase |
Handles the icon registry not being able to find icons whose ids contain unescaped characters (e.g. spaces). Note that for this example in particular having a space in the id is invalid, however I did it since supporting it is trivial. Fixes angular#15673.
|
Rebased. |
crisbeto
force-pushed
the
15673/icon-unescaped-characters
branch
from
8ec5964 to
8dfe10e
Compare
|
Rebased. |
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
Handles the icon registry not being able to find icons whose ids contain unescaped characters (e.g. spaces). Note that for this example in particular having a space in the id is invalid, however I did it since supporting it is trivial. Fixes angular#15673.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles the icon registry not being able to find icons whose ids contain unescaped characters (e.g. spaces).
Note that for this example in particular having a space in the id is invalid, however I did it since supporting it is trivial.
Fixes #15673.