Skip to content

fix(chips): remove aria-selected from deselected chip in single selection mode #15634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2019
Merged

fix(chips): remove aria-selected from deselected chip in single selection mode #15634

merged 1 commit into from
Mar 28, 2019

Conversation

crisbeto
Copy link
Member

Along the same lines as #15617 since the setup between mat-select and mat-chip-list fairly similar. Removes the aria-selected from deselected chips in single selection mode in order to reduce the amount of noise for screen reader users.

@crisbeto
fix(chips): remove aria-selected from deselected chip in single selec…
e850356 
…tion mode

Along the same lines as angular#15617 since the setup between `mat-select` and `mat-chip-list` fairly similar. Removes the `aria-selected` from deselected chips in single selection mode in order to reduce the amount of noise for screen reader users.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 27, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner March 27, 2019 21:57
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 27, 2019
@jelbourn jelbourn added the Accessibility This issue is related to accessibility (a11y) label Mar 27, 2019
jelbourn
jelbourn approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 27, 2019
@jelbourn jelbourn merged commit 80538ef into angular:master Mar 28, 2019
jelbourn pushed a commit that referenced this pull request Apr 4, 2019
@crisbeto @jelbourn
fix(chips): remove aria-selected from deselected chip in single selec…
ebbf97e 
…tion mode (#15634)

Along the same lines as #15617 since the setup between `mat-select` and `mat-chip-list` fairly similar. Removes the `aria-selected` from deselected chips in single selection mode in order to reduce the amount of noise for screen reader users.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot