fix(autocomplete): not emitting opened event if options come in after open #15582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Mar 27, 2019
| if (this.panelOpen) { | ||
| this._overlayRef!.updatePosition(); | ||
|
|
||
| if (wasOpen !== this.panelOpen) { |
There was a problem hiding this comment.
Add a comment here that captures the context for this PR?
crisbeto
force-pushed
the
15573/autocomplete-open-event
branch
from
1f4a42c to
e5f62b7
Compare
|
Addressed the feedback @jelbourn. |
|
@crisbeto this passes presubmit, just needs a rebase |
… open Fixes `mat-autocomplete` not emitting its `opened` event if it is opened without any options and then the options come in at a later point. Fixes angular#15573.
|
Rebased. |
crisbeto
force-pushed
the
15573/autocomplete-open-event
branch
from
e5f62b7 to
face478
Compare
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
… open (angular#15582) Fixes `mat-autocomplete` not emitting its `opened` event if it is opened without any options and then the options come in at a later point. Fixes angular#15573.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
mat-autocompletenot emitting itsopenedevent if it is opened without any options and then the options come in at a later point.Fixes #15573.