Skip to content

docs(dialog): add doc for align attribute #15500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

crisbeto
Copy link
Member

Adds a sentence to the docs about the align attribute of the dialog content. We can't document it through doc strings, because it isn't defined in TS.

Fixes #15482.

Adds a sentence to the docs about the `align` attribute of the dialog content. We can't document it through doc strings, because it isn't defined in TS.

Fixes angular#15482.
@crisbeto crisbeto added docs This issue is related to documentation pr: merge safe target: patch This PR is targeted for the next patch release labels Mar 15, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner March 15, 2019 21:35
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 15, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 15, 2019
@mmalerba mmalerba merged commit c8ddaa8 into angular:master Mar 15, 2019
mmalerba pushed a commit that referenced this pull request Mar 18, 2019
Adds a sentence to the docs about the `align` attribute of the dialog content. We can't document it through doc strings, because it isn't defined in TS.

Fixes #15482.
mmalerba pushed a commit that referenced this pull request Mar 18, 2019
Adds a sentence to the docs about the `align` attribute of the dialog content. We can't document it through doc strings, because it isn't defined in TS.

Fixes #15482.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MatDialog: "align" attribute appears to not be documented
3 participants