fix(menu): not closed correctly if opened by different trigger while visible #15373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
When this PR can be merged ? |
crisbeto
force-pushed
the
15354/menu-multiple-trigger
branch
from
369ca01 to
4bc8f63
Compare
crisbeto
force-pushed
the
15354/menu-multiple-trigger
branch
2 times, most recently
from
0c51b2c to
d3e0f36
Compare
andrewseguin
added
the
P3
crisbeto
force-pushed
the
15354/menu-multiple-trigger
branch
from
d3e0f36 to
949bd88
Compare
crisbeto
force-pushed
the
15354/menu-multiple-trigger
branch
from
949bd88 to
078951d
Compare
crisbeto
force-pushed
the
15354/menu-multiple-trigger
branch
from
078951d to
f581ea3
Compare
crisbeto
force-pushed
the
15354/menu-multiple-trigger
branch
from
f581ea3 to
06943e1
Compare
…visible Fixes the `MatMenu` overlay not being detached if the menu is opened by a different trigger while the panel is still open. Fixes angular#15354.
crisbeto
force-pushed
the
15354/menu-multiple-trigger
branch
from
06943e1 to
a431705
Compare
|
@crisbeto It looks like this PR is outdated, please rebase the PR. |
andrewseguin
removed
the
cla: yes
andrewseguin
removed
the
P3
josephperrott
added
action: cleanup
|
No longer needed after #30163. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
MatMenuoverlay not being detached if the menu is opened by a different trigger while the panel is still open.Fixes #15354.