-
Notifications
You must be signed in to change notification settings - Fork 6.8k
test(overlay): use static queries w/ overlay containers #15301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(overlay): use static queries w/ overlay containers #15301
Conversation
d3d9a3b
to
817978f
Compare
@@ -111,7 +111,7 @@ describe('FullscreenOverlayContainer', () => { | |||
providers: [Overlay], | |||
}) | |||
class TestComponentWithTemplatePortals { | |||
@ViewChild(CdkPortal) templatePortal: CdkPortal; | |||
@ViewChild(CdkPortal, {static: true}) templatePortal: CdkPortal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should put in detectChanges
calls instead? My guess here is that the first test used static queries and then we ended up copying it everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to use static
for this one since it keeps the test as running just one change detection, even though it's largely trivial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.