Skip to content

chore(ivy): fix static query stragglers that were not marked static q… #15267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2019
Merged

chore(ivy): fix static query stragglers that were not marked static q… #15267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cdk/table/table.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2108,7 +2108,7 @@ class WrapperCdkTableApp<T> implements AfterContentInit {
@ContentChild(CdkHeaderRowDef) headerRowDef: CdkHeaderRowDef;
@ContentChildren(CdkRowDef) rowDefs: QueryList<CdkRowDef<T>>;

@ViewChild(CdkTable) table: CdkTable<T>;
@ViewChild(CdkTable, {static: true}) table: CdkTable<T>;

@Input() columns: string[];
@Input() dataSource: DataSource<T>;
Expand Down
7 changes: 3 additions & 4 deletions src/lib/paginator/paginator.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ describe('MatPaginator', () => {

beforeEach(() => {
fixture = TestBed.createComponent(MatPaginatorApp);
fixture.detectChanges();

component = fixture.componentInstance;
paginator = component.paginator;

fixture.detectChanges();
});

describe('with the default internationalization provider', () => {
Expand Down Expand Up @@ -368,10 +368,9 @@ describe('MatPaginator', () => {

it('should handle the number inputs being passed in as strings', () => {
const withStringFixture = TestBed.createComponent(MatPaginatorWithStringValues);
const withStringPaginator = withStringFixture.componentInstance.paginator;

withStringFixture.detectChanges();

const withStringPaginator = withStringFixture.componentInstance.paginator;
expect(withStringPaginator.pageIndex).toEqual(0);
expect(withStringPaginator.length).toEqual(100);
expect(withStringPaginator.pageSize).toEqual(10);
Expand Down
2 changes: 2 additions & 0 deletions src/lib/slide-toggle/slide-toggle.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,8 @@ describe('MatSlideToggle without forms', () => {
]
});
const fixture = TestBed.createComponent(SlideToggleBasic);
fixture.detectChanges();

const testComponent = fixture.debugElement.componentInstance;
const slideToggleDebug = fixture.debugElement.query(By.css('mat-slide-toggle'));

Expand Down