fix(a11y): don't set aria description if it's the same as the node's aria-label #15250
Conversation
crisbeto
added
Accessibility
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
15048/aria-describer-aria-label
branch
from
e1cba77 to
813ad85
Compare
| return false; | ||
| } | ||
|
|
||
| const trimmedMessage = message == null ? '' : `${message}`.trim(); |
There was a problem hiding this comment.
Unnecessary template string literal? Also, omit the == null?
message ? '' : message.trim();Alternatively,
const trimmedMessage = `${message || ''}`.trim();The function signature also indicates that message can't be null or undefined. Should it include those?
There was a problem hiding this comment.
``${message || ''}.trim(); will swallow values like `0` or `false`. Even though the signature doesn't allow these values, we have some cases where the values from the view get passed straight into this method.
|
|
||
| // We shouldn't set descriptions if they're exactly the same as the `aria-label` of the element, | ||
| // because screen readers will end up reading out the same text twice in a row. | ||
| return trimmedMessage ? element.getAttribute('aria-label') !== trimmedMessage : false; |
There was a problem hiding this comment.
Trim the aria-label as well?
Probably not a big deal, but it might make sense to also normalize the whitespace for both.
…aria-label As per a recent discussion, reworks the `AriaDescriber` not to set the `aria-describedby`, if the message will be exactly the same as an existing `aria-label` on the element. This avoids the same text being read out twice. Fixes angular#15048.
crisbeto
force-pushed
the
15048/aria-describer-aria-label
branch
from
813ad85 to
95f576c
Compare
|
The feedback has been addressed @jelbourn. |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
As per a recent discussion, reworks the
AriaDescribernot to set thearia-describedby, if the message will be exactly the same as an existingaria-labelon the element. This avoids the same text being read out twice.Fixes #15048.