Skip to content

docs(stepper): update non-default boolean for editable prop #15161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2019
Merged

docs(stepper): update non-default boolean for editable prop #15161

merged 1 commit into from
Feb 13, 2019

Conversation

cbejensen
Copy link
Contributor

Previously, the docs said editable can be set to true, but that is the default, so it makes more sense to say they can be set to false to change the default behavior.

@cbejensen
docs(stepper): update non-default boolean for editable prop
569a225 
Previously, the docs said editable can be set to true, but that is the default, so it makes more sense to say they can be set to false to change the default behavior.
@cbejensen cbejensen requested a review from mmalerba as a code owner February 12, 2019 15:12
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 12, 2019
crisbeto
crisbeto approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 12, 2019
jelbourn
jelbourn approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit e1d0024 into angular:master Feb 13, 2019
jelbourn pushed a commit that referenced this pull request Feb 20, 2019
@cbejensen @jelbourn
docs(stepper): update non-default boolean for editable prop (#15161)
1af6f8c 
Previously, the docs said editable can be set to true, but that is the default, so it makes more sense to say they can be set to false to change the default behavior.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cbejensen @jelbourn @crisbeto @googlebot