Skip to content

fix: add dependency on @angular/forms #15133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 9, 2019

Adds @angular/forms to the list of dependencies, because there are around 10 Material components that are importing symbols from it.

Fixes #15085.

@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Feb 9, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner February 9, 2019 15:36
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 9, 2019
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make sure that ng add installs @angular/forms if it's not installed yet.

Adds `@angular/forms` to the list of dependencies, because there are around 10 Material components that are importing symbols from it.

Fixes angular#15085.
@crisbeto crisbeto force-pushed the 15085/forms-dependency branch from eed33d0 to 6219b23 Compare February 9, 2019 17:43
@crisbeto
Copy link
Member Author

crisbeto commented Feb 9, 2019

Ah, totally forgot about the schematics. I've added it.

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker pr: merge safe labels Feb 20, 2019
@jelbourn jelbourn merged commit 8fc97ac into angular:master Feb 20, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependency to @angular/forms
4 participants