Skip to content

fix(docs): Icons in the toolbar example are missing alternative text … #15128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2019
Merged

fix(docs): Icons in the toolbar example are missing alternative text … #15128

merged 2 commits into from
Feb 14, 2019

Conversation

Suresh918
Copy link
Contributor

@Suresh918 Suresh918 commented Feb 8, 2019 •
edited
Loading

Fixes #15041

@Suresh918 Suresh918 requested a review from jelbourn as a code owner February 8, 2019 15:53
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 8, 2019
crisbeto
crisbeto reviewed Feb 10, 2019
View reviewed changes
src/material-examples/toolbar-multirow/toolbar-multirow-example.html Outdated
<mat-icon class="example-icon">delete</mat-icon>
<span class="cdk-visually-hidden">Example delete icon</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These labels should be set as an aria-label on the mat-icon, rather than a span next to it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed as per your suggestion. Can you please check now

jelbourn
jelbourn approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think that this example needs some other improvements since the the toolbar is basically just a colored div, but that can be dealt with at some future date.

@jelbourn jelbourn added pr: lgtm docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Feb 14, 2019
@jelbourn jelbourn merged commit aff565a into angular:master Feb 14, 2019
jelbourn pushed a commit that referenced this pull request Feb 20, 2019
@Suresh918 @jelbourn
docs(toolbar): add aria-labels to icons in example (#15128)
e7d22b5 
Fixes #15041
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icons in the toolbar example are missing alternative text
4 participants
@Suresh918 @jelbourn @crisbeto @googlebot