build: branch manager should use "7.3.x" as patch branch #15097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the branch manager to validate patch PRs against the `7.3.x` branch. This is necessary because currently some PRs are marked as failing because they no longer apply to the outdated `7.2.x` branch.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
|
Ideally, we would have it automated. I will have to think through about how to do that best. |
josephperrott
approved these changes
Feb 6, 2019
jelbourn
pushed a commit
that referenced
this pull request
Feb 11, 2019
Updates the branch manager to validate patch PRs against the `7.3.x` branch. This is necessary because currently some PRs are marked as failing because they no longer apply to the outdated `7.2.x` branch.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the branch manager to validate patch PRs against the
7.3.xbranch. This is necessary because currently some PRs are marked as failing because they no longer apply to the outdated7.2.xbranch.cc. @josephperrott should we somehow add this to the release instructions? or should the branch manager automatically pick up the proper branch somehow (e.g. by checking the "package.json")