fix(list): selection list not picking up indirect descendants #15003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes `MatSelectionList` not picking up list options that aren't direct descendants. **Note:** this approach can have some side-effects if somebody decided to nested selection lists which would result in the parent picking up the options of its children. We can handle that case with some extra code, however I decided not to for now since it doesn't make sense to nest lists. Fixes angular#15000.
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jan 29, 2019
jelbourn
added
pr: lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Feb 4, 2019
Fixes `MatSelectionList` not picking up list options that aren't direct descendants. **Note:** this approach can have some side-effects if somebody decided to nest selection lists which would result in the parent picking up the options of its children. We can handle that case with some extra code, however I decided not to for now since it doesn't make sense to nest lists. Fixes #15000.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
MatSelectionListnot picking up list options that aren't direct descendants.Note: this approach can have some side-effects if somebody decided to nest selection lists which would result in the parent picking up the options of its children. We can handle that case with some extra code, however I decided not to for now since it doesn't make sense to nest lists.
Fixes #15000.