Skip to content

fix(slider): focus ring showing when ancestor has focus monitoring #14960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2019
Merged

fix(slider): focus ring showing when ancestor has focus monitoring #14960

merged 1 commit into from
Jan 30, 2019

Conversation

crisbeto
Copy link
Member

Fixes an overly-broad selector that meant that the slider's focus ring would show if any of its ancestors has focus monitoring.

Fixes #14958.

@crisbeto
fix(slider): focus ring showing when ancestor has focus monitoring
3e10be4 
Fixes an overly-broad selector that meant that the slider's focus ring would show if any of its ancestors has focus monitoring.

Fixes angular#14958.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 25, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 25, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 25, 2019
@mmalerba mmalerba merged commit 07433fd into angular:master Jan 30, 2019
mmalerba pushed a commit that referenced this pull request Feb 4, 2019
@crisbeto @mmalerba
fix(slider): focus ring showing when ancestor has focus monitoring (#…
2ec9dff 
…14960)

Fixes an overly-broad selector that meant that the slider's focus ring would show if any of its ancestors has focus monitoring.

Fixes #14958.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mat-slider] slider is visually focused when parent is focused and uses cdkMonitorSubtreeFocus directive
3 participants
@crisbeto @googlebot @mmalerba