Skip to content

chore: add script to generate ivy test blacklist #14877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2019
Merged

chore: add script to generate ivy test blacklist #14877

merged 1 commit into from
Jan 18, 2019

Conversation

jelbourn
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 17, 2019
devversion
devversion approved these changes Jan 18, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

scripts/ivy/generate-blacklist.js
const path = require('path');
const fs = require('fs');

const karmaOutput = JSON.parse(fs.readFileSync('/tmp/karma-result.json'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could probably make this as a CLI arg as well. I'm sure it doesn't matter too much, so just nit.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 18, 2019
@ngbot
Copy link

ngbot bot commented Jan 18, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: build_release_packages" is failing
    failure status "ci/circleci: tests_local_browsers" is failing
    failure status "ci/circleci: lint" is failing
    failure status "ci/circleci: e2e_tests" is failing
    failure status "ci/circleci: tests_browserstack" is failing
    failure status "ci/circleci: prerender_build" is failing
    failure status "ci/circleci: tests_saucelabs" is failing
    failure status "ci/circleci: api_golden_checks" is failing
    failure status "ci/circleci: bazel_build_test" is failing
    pending missing required labels: target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit 031b06f into angular:ivy-2019 Jan 18, 2019
kara pushed a commit that referenced this pull request Mar 20, 2019
@jelbourn @kara
chore: add script to generate ivy test blacklist (#14877)
e7521ac
JoostK pushed a commit to JoostK/components that referenced this pull request May 7, 2019
@jelbourn @JoostK
chore: add script to generate ivy test blacklist (angular#14877)
f715462
JoostK pushed a commit to JoostK/components that referenced this pull request Jul 9, 2019
@jelbourn @JoostK
chore: add script to generate ivy test blacklist (angular#14877)
26e00a7
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jelbourn @devversion @googlebot