fix(list): disableRipple on list input not taking effect after init #14836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
14824/list-disable-ripple
branch
from
6f4c198 to
8544591
Compare
crisbeto
added
target: patch
Fixes the `disableRipple` on the list not having an effect if it's changed through the input after init. Fixes angular#14824.
crisbeto
force-pushed
the
14824/list-disable-ripple
branch
from
8544591 to
3bb3809
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 16, 2019
… after init Along the same lines as angular#14836. Fixes changes to `disableRipple` not being propagated immediately the list options.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 17, 2019
… after init Along the same lines as angular#14836. Fixes changes to `disableRipple` not being propagated immediately the list options.
s2-abdo
pushed a commit
to s2-abdo/material2
that referenced
this pull request
Jan 18, 2019
…ngular#14836) Fixes the `disableRipple` on the list not having an effect if it's changed through the input after init. Fixes angular#14824.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 9, 2019
… after init Along the same lines as angular#14836. Fixes changes to `disableRipple` not being propagated immediately the list options.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
disableRippleon the list not having an effect if it's changed through the input after init.Fixes #14824.