Skip to content

refactor(list): refactor component inputs #14804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2019
Merged

refactor(list): refactor component inputs #14804

merged 1 commit into from
Jan 17, 2019

Conversation

swseverance
Copy link
Contributor

  • remove disabled and tabIndex from MatSelectionList array
    of inputs. disabled and tabIndex properties of the component
    are already decorated with @Input() decorator

@swseverance
refactor(list): refactor component inputs
32f2d9f 
* remove `disabled` and `tabIndex` from `MatSelectionList` array
  of inputs. `disabled` and `tabIndex` properties of the component
  are already decorated with `@Input()` decorator
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 12, 2019
crisbeto
crisbeto approved these changes Jan 12, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think these are a leftover from when we were using mixins for them.

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 12, 2019
@vivian-hu-zz vivian-hu-zz merged commit 63e6a67 into angular:master Jan 17, 2019
s2-abdo pushed a commit to s2-abdo/material2 that referenced this pull request Jan 18, 2019
@swseverance
refactor(list): refactor component inputs (angular#14804)
4d6b0fb 
* remove `disabled` and `tabIndex` from `MatSelectionList` array
  of inputs. `disabled` and `tabIndex` properties of the component
  are already decorated with `@Input()` decorator
vivian-hu-zz pushed a commit that referenced this pull request Jan 18, 2019
@swseverance
refactor(list): refactor component inputs (#14804)
27a9031 
* remove `disabled` and `tabIndex` from `MatSelectionList` array
  of inputs. `disabled` and `tabIndex` properties of the component
  are already decorated with `@Input()` decorator
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swseverance @crisbeto @googlebot @vivian-hu-zz