Skip to content

chore: create branch-manager.yml config file #14523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2018
Merged

chore: create branch-manager.yml config file #14523

merged 1 commit into from
Dec 14, 2018

Conversation

josephperrott
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 14, 2018
@josephperrott josephperrott added pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 14, 2018
devversion
devversion approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@devversion devversion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very cool!

Just my opinion, I personally would not add additional whitespaces to YAML as they are just superfluous.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 14, 2018
@josephperrott
Copy link
Member Author

@devversion additional whitespace with blank lines or with alignment after the colon?

@devversion
Copy link
Member

Just meant the whitespace in between the property and the value (so after the colon yeah)

@josephperrott josephperrott force-pushed the create-branch-manager-config branch from d1c3c80 to e873e45 Compare December 14, 2018 15:50
@josephperrott josephperrott merged commit bc8fc75 into angular:master Dec 14, 2018
@josephperrott josephperrott deleted the create-branch-manager-config branch December 14, 2018 17:13
josephperrott added a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@josephperrott
chore: create branch-manager.yml config file (angular#14523)
1a3fda1
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@vivian-hu-zz vivian-hu-zz Awaiting requested review from vivian-hu-zz

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephperrott @devversion @googlebot