fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled #14413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
merge: caretaker note
googlebot
added
the
cla: yes
|
Caretaker note: this is a resubmit of #13774 which had to be reverted due to sync issues. |
crisbeto
force-pushed
the
13734/autocomplete-auto-active-float-label
branch
from
91d90df to
63be232
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the first option not appearing as highlighted if the consumer has set
floatLabel="never"andautoActiveFirstOption. It looks like we were depending on thetransitionedevent from the label to kick off the change detection that shows the highlight.Fixes #13734.