Skip to content

build: package docs content into npm package #14411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

  • Packages the Bazel generated docs content into the Bazel generated ng_package of the material-examples.

Note: In a follow-up I will try to wire this up in the publish script.

* Packages the Bazel generated docs content into the Bazel generated `ng_package` of the `material-examples`.
@devversion devversion added in progress This issue is currently in progress pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 6, 2018
@devversion devversion requested a review from jelbourn as a code owner December 6, 2018 19:44
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 6, 2018
@devversion
Copy link
Member Author

devversion commented Dec 6, 2018

This is ready one is ready for review. We still need to package the API overviews into the docs-content, but that one will be a follow-up.

I'm confident that packaging the docs content through Bazel will pay off in the long-term.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 6, 2018
@ngbot
Copy link

ngbot bot commented Dec 6, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure conflicts with base branch "master"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@ngbot
Copy link

ngbot bot commented Dec 6, 2018

Hi @devversion! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@mmalerba mmalerba merged commit b2788bf into angular:master Dec 6, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
* build: package docs content into npm package

* Packages the Bazel generated docs content into the Bazel generated `ng_package` of the `material-examples`.

* Package overviews for CDK and Material into the docs content
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement in progress This issue is currently in progress target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants