Skip to content

build: remove unused dependencies #14353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2018
Merged

build: remove unused dependencies #14353

merged 1 commit into from
Dec 4, 2018

Conversation

devversion
Copy link
Member

No description provided.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 2, 2018
@devversion devversion requested a review from jelbourn as a code owner December 2, 2018 18:29
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 2, 2018
@ngbot
Copy link

ngbot bot commented Dec 3, 2018

Hi @devversion! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

jelbourn
jelbourn approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs rebase

@devversion devversion force-pushed the build/remove-unused-deps branch from 53176eb to 043b499 Compare December 4, 2018 10:28
@devversion devversion force-pushed the build/remove-unused-deps branch from 043b499 to de55491 Compare December 4, 2018 10:42
@devversion
Copy link
Member Author

@jelbourn FYI: I've locked the TypeScript version in the package.json here because otherwise we might end up retrieving a version that doesn't work with @angular/bazel or @schematics/angular.

Technically this is already locked in the lock file, but if someone refreshes the lock file completely, this will result in an incorrect TypeScript version. Just to ensure that this doesn't happen and matches angular/angular

@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Dec 4, 2018
@mmalerba mmalerba merged commit d741983 into angular:master Dec 4, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@devversion @josephperrott
build: remove unused dependencies (angular#14353)
62371ab
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @mmalerba