Skip to content

build: bump to latest jasmine #14188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

crisbeto
Copy link
Member

Bumps to the latest Jasmine version which includes some new APIs like expect().withContext().

@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 18, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner November 18, 2018 11:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 18, 2018
Bumps to the latest Jasmine version which includes some new APIs like `expect().withContext()`.
@crisbeto crisbeto force-pushed the jasmine-matcher-update branch from e28a097 to 544933b Compare November 19, 2018 22:25
@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 20, 2018
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott merged commit e048c2a into angular:master Nov 20, 2018
josephperrott pushed a commit that referenced this pull request Nov 20, 2018
josephperrott pushed a commit that referenced this pull request Nov 20, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants