-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Update to angular 7.0.4 and latest rules_nodejs #14181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
//cc @alexeagle |
The other changes are cool, really like the |
in `package.json` and `tools/npm/package.json` must match the version of the | ||
`@angular` `http_archive` in `WORKSPACE`. For this reason, `@angular/bazel` | ||
should be pinned to a specific version in both `package.json` files. If updating | ||
the version of the angular http_archive, ensure sure that all 3 versions line up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to just be an automatic check in our release script, otherwise it will 100% get broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should chat about that tools/npm/package.json
file. Based on some testing it's just needed because the Angular Bazel rules fall back to @npm
for the compiler binaries etc.
RxJS apparently uses their own workspace now, and the comment about why we need this (just for rxjs) is no longer up-to date I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still needed for rxjs since it uses ts_library in there which depends on the @npm
workspace. An rxjs release with a named UMD bundle is in the works (ReactiveX/rxjs#4309). When that lands and makes it into a release then the build can be updated to no longer build RXJS from source.
@@ -89,7 +90,7 @@ load("@build_bazel_rules_typescript//:defs.bzl", "ts_setup_workspace") | |||
ts_setup_workspace() | |||
|
|||
# Setup the Sass rule repositories. | |||
load("@io_bazel_rules_sass//:defs.bzl", "sass_repositories") | |||
load("@io_bazel_rules_sass//sass:sass_repositories.bzl", "sass_repositories") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK this should stay :defs
. @devversion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's the new public API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You guys are right. It's the downstream repo that is out of date. Thanks.
Looks like everything in here is covered by the other PRs. Note: (#14173) rules_nodejs 0.16.1 won't work with material but the latest commit will (symlink issue fixed by bazel-contrib/rules_nodejs#422). you can either update to that commit or Alex should tag 0.16.2 shortly. With the rules_nodejs update, the update to yarn 1.10+ is possible as well. I'll create an issue for the release script update. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
A few issues in the downstream Bazel build that this fixes.
rules_sass was on an older version that was using
load
paths that are no longer valid in the newest version. Update to latest version and updated load paths.the version of
@angular/bazel
in package.json (^7.0.3
but pinned to7.0.3
in the lock file) causes a version skew issue downstream in angular-bazel-example when updating to angular 7.0.4. For the time being, this version needs to be pinned to a specific version that matches the angular http_archive version in WORKSPACE. the exact version match requirement will be relaxed to a range in the future and with Ivy this will no longer be an issue since the downstream Bazel build will use the material bundlesI added a
RELEASING.md
file to remind the caretaker to match up these versions when releasingOther updates:
integrity
lock field which is removed from the lock file whenyarn_install
runs with a pre-1.10 version of yarn