Skip to content

build: run saucelabs browsers in parallel #14106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2018
Merged

build: run saucelabs browsers in parallel #14106

merged 1 commit into from
Nov 19, 2018

Conversation

devversion
Copy link
Member

Since we run only one browsers on Saucelabs, we can run the browser twice in order to speed up the tests.

@devversion devversion added the in progress This issue is currently in progress label Nov 12, 2018
@devversion devversion requested a review from jelbourn as a code owner November 12, 2018 19:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 12, 2018
@devversion devversion force-pushed the build/run-saucelabs-parallel branch from ea4e0d2 to f1dafc6 Compare November 12, 2018 19:20
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release and removed in progress This issue is currently in progress labels Nov 12, 2018
jelbourn
jelbourn approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 14, 2018
@ngbot
Copy link

ngbot bot commented Nov 14, 2018

Hi @devversion! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@devversion devversion force-pushed the build/run-saucelabs-parallel branch from f1dafc6 to 9b5cb59 Compare November 14, 2018 22:42
@devversion
Copy link
Member Author

@andrewseguin Rebased (just failing because of the API guardian).

@devversion devversion force-pushed the build/run-saucelabs-parallel branch from 9b5cb59 to 882b250 Compare November 16, 2018 17:24
@josephperrott josephperrott merged commit 1013758 into angular:master Nov 19, 2018
josephperrott pushed a commit that referenced this pull request Nov 19, 2018
@devversion @josephperrott
build: run saucelabs browsers in parallel (#14106)
f229f9e
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @jelbourn @googlebot @josephperrott @andrewseguin