Skip to content

build: suppress warnings when building tests with bazel #13816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2018
Merged

build: suppress warnings when building tests with bazel #13816

merged 1 commit into from
Oct 25, 2018

Conversation

devversion
Copy link
Member

  • Suppress Bazel warnings when compiling the unit tests. This is necessary for the test tsconfig because TypeScript does not inherit third-party tsconfig options.

@devversion
build: supress warnings when building tests with bazel
e818f40 
* Suppress Bazel warnings when compiling the unit tests. This is necessary for the test tsconfig because TypeScript does not inherit third-party `tsconfig` options.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 25, 2018
@devversion devversion requested a review from jelbourn as a code owner October 25, 2018 16:45
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 25, 2018
jelbourn
jelbourn approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 25, 2018
@mmalerba mmalerba merged commit ea9354e into angular:master Oct 25, 2018
mmalerba pushed a commit that referenced this pull request Oct 26, 2018
@devversion @mmalerba
build: suppress warnings when building tests with bazel (#13816)
5b5ceef 
* Suppress Bazel warnings when compiling the unit tests. This is necessary for the test tsconfig because TypeScript does not inherit third-party `tsconfig` options.
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
@devversion @atscott
build: suppress warnings when building tests with bazel (angular#13816)
7aae8a8 
* Suppress Bazel warnings when compiling the unit tests. This is necessary for the test tsconfig because TypeScript does not inherit third-party `tsconfig` options.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @mmalerba