Skip to content

build: move aot and prerender jobs to circleci #13690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2018
Merged

build: move aot and prerender jobs to circleci #13690

merged 1 commit into from
Oct 19, 2018

Conversation

devversion
Copy link
Member

No description provided.

@devversion devversion requested a review from jelbourn as a code owner October 19, 2018 17:54
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 19, 2018
josephperrott
josephperrott reviewed Oct 19, 2018
View reviewed changes
.circleci/config.yml Outdated
@@ -162,6 +193,8 @@ workflows:
integration_tests:
jobs:
- e2e_tests
- prerender
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was named prerender-check in jobs list above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@devversion devversion force-pushed the build/move-aot-and-prerender-circleci branch from 98c0445 to 06cb1cb Compare October 19, 2018 17:57
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 19, 2018
@devversion
Copy link
Member Author

devversion commented Oct 19, 2018 •
edited
Loading

I think since we have enough containers and don't acquire those for more than a few minutes, we can have the prerender and aot checks in individual jobs. Once we run into issues where other jobs don't run because of too less containers, we can always combine the job into one.

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 19, 2018
josephperrott
josephperrott approved these changes Oct 19, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott merged commit fb8496d into angular:master Oct 19, 2018
@devversion devversion deleted the build/move-aot-and-prerender-circleci branch October 19, 2018 20:44
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @josephperrott @jelbourn @googlebot