refactor(platform): add utility to normalize passive event listener options #13533
Conversation
crisbeto
added
merge: caretaker note
crisbeto
requested review from
devversion,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
|
Caretaker note: targeting |
| * `options` parameter. | ||
| * @param options Object to be normalized. | ||
| */ | ||
| export function normalizePassiveEventListenerOptions(options: AddEventListenerOptions): |
There was a problem hiding this comment.
I would be good with shortening this to normalizePassiveListenerOptions
| * `options` parameter. | ||
| * @param options Object to be normalized. | ||
| */ | ||
| export function normalizePassiveEventListenerOptions(options: AddEventListenerOptions): |
There was a problem hiding this comment.
Add a unit test for this function specifically?
There was a problem hiding this comment.
That won’t be very reliable, because the result depends on whether the browser supports passive events.
jelbourn
added
pr: lgtm
action: merge
crisbeto
force-pushed
the
normalize-options-util
branch
from
04f11bc to
0028486
Compare
crisbeto
added
target: patch
josephperrott
added
pr: needs rebase
and removed
action: merge
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
…ptions Every time we consume the `supportsPassiveEventListeners` function, we do some kind of ternary that handles the fallback in case the browser doesn't support passive listeners. Since this can be cumbersome and error-prone, these changes add a function that will normalize the object automatically.
crisbeto
force-pushed
the
normalize-options-util
branch
from
0028486 to
f00e98a
Compare
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Every time we consume the
supportsPassiveEventListenersfunction, we do some kind of ternary that handles the fallback in case the browser doesn't support passive listeners. Since this can be cumbersome and error-prone, these changes add a function that will normalize the object automatically.