-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(drag-drop): convert cdk-drop into a directive #13441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/** | ||
* @license | ||
* Copyright Google LLC All Rights Reserved. | ||
* | ||
* Use of this source code is governed by an MIT-style license that can be | ||
* found in the LICENSE file at https://angular.io/license | ||
*/ | ||
|
||
/** | ||
* Extended CSSStyleDeclaration that includes a couple of drag-related | ||
* properties that aren't in the built-in TS typings. | ||
*/ | ||
interface DragCSSStyleDeclaration extends CSSStyleDeclaration { | ||
webkitUserDrag: string; | ||
MozUserSelect: string; // For some reason the Firefox property is in PascalCase. | ||
} | ||
|
||
/** | ||
* Shallow-extends a stylesheet object with another stylesheet object. | ||
* @docs-private | ||
*/ | ||
export function extendStyles(dest: CSSStyleDeclaration, source: Partial<DragCSSStyleDeclaration>) { | ||
for (let key in source) { | ||
if (source.hasOwnProperty(key)) { | ||
dest[key!] = source[key]; | ||
} | ||
} | ||
|
||
return dest; | ||
} | ||
|
||
|
||
/** | ||
* Toggles whether the native drag interactions should be enabled for an element. | ||
* @param element Element on which to toggle the drag interactions. | ||
* @param enable Whether the drag interactions should be enabled. | ||
* @docs-private | ||
*/ | ||
export function toggleNativeDragInteractions(element: HTMLElement, enable: boolean) { | ||
const userSelect = enable ? '' : 'none'; | ||
|
||
extendStyles(element.style, { | ||
touchAction: enable ? '' : 'none', | ||
webkitUserDrag: enable ? '' : 'none', | ||
webkitTapHighlightColor: enable ? '' : 'transparent', | ||
userSelect: userSelect, | ||
msUserSelect: userSelect, | ||
webkitUserSelect: userSelect, | ||
MozUserSelect: userSelect | ||
}); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've dropped this test and I haven't added new ones for the other elements that need to get these styles at runtime, because not all of the properties that are added are supported on the browsers that we test against, which will lead to flakes.