Skip to content

feat: add support for noImplicitThis #13404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2018
Merged

feat: add support for noImplicitThis #13404

merged 1 commit into from
Oct 17, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 3, 2018

Adds support for the noImplicitThis compiler option and fixes the compilation errors.

@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Oct 3, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 3, 2018
devversion
devversion approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What strict checks are missing? At some we could also just use strict which enables all individual strict flags.

src/cdk/a11y/interactivity-checker/interactivity-checker.spec.ts
@@ -509,7 +509,7 @@ describe('InteractivityChecker', () => {
}
}

function runIf(condition: boolean, runFn: Function): () => void {
function runIf(this: any, condition: boolean, runFn: Function): () => void {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a second, I thought that this is an actual parameter.

@crisbeto
Copy link
Member Author

crisbeto commented Oct 3, 2018

This should be the last one missing from the strict flag. I talked to @jelbourn about it, but we decided not to use strict, because things can start breaking if the TS team adds another check to it.

@devversion
Copy link
Member

@crisbeto Yeah that makes sense. I assumed they would only add these in major releases (where we can expect such breaking changes)

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 3, 2018
jelbourn
jelbourn approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngbot
Copy link

ngbot bot commented Oct 5, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto crisbeto force-pushed the no-implicit-this branch 2 times, most recently from aa78b13 to 8fd0b55 Compare October 12, 2018 13:36
@josephperrott
Copy link
Member

@crisbeto Looks like the e2e tests are failing on this now?

I was able to reproduce the failure locally, though at a glance am unsure of the cause.

@crisbeto crisbeto force-pushed the no-implicit-this branch 2 times, most recently from 5e00702 to b3e6a2e Compare October 17, 2018 05:56
@crisbeto
Copy link
Member Author

Fixed @josephperrott.

@crisbeto
feat: add support for noImplicitThis
5154d22 
Adds support for the `noImplicitThis` compiler option and fixes the compilation errors.
@josephperrott josephperrott merged commit 97703be into angular:master Oct 17, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @devversion @josephperrott @jelbourn @googlebot