Skip to content

feat(schematics): CDK support for ng-update #13303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

  • Introduces support for ng update of @angular/cdk. The Angular Material update schematic will share code with the CDK schematics code.

@devversion devversion added in progress This issue is currently in progress target: major This PR is targeted for the next major release labels Sep 25, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 25, 2018
* Introduces support for `ng update` of `@angular/cdk`. The Angular Material update schematic will share code with the CDK schematics code.
@devversion devversion force-pushed the feat/schematics-support-ng-update branch from b33518b to 8d363fe Compare September 25, 2018 15:11
@devversion devversion added pr: merge safe and removed in progress This issue is currently in progress labels Sep 25, 2018
@devversion
Copy link
Member Author

@jelbourn Should be ready for review. A few missing JSDoc description might appear, but those were missing before already and will be fixed in a follow-up (this PR is already big enough)

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 25, 2018
@jelbourn jelbourn merged commit 1afddfb into angular:master Sep 25, 2018
@devversion devversion deleted the feat/schematics-support-ng-update branch September 28, 2018 10:36
@Splaktar Splaktar changed the title feat(schematics): support for ng-update. feat(schematics): CDK support for ng-update Oct 5, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
Introduces support for `ng update` of `@angular/cdk`. The Angular Material update schematic will share code with the CDK schematics code.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants