Skip to content

fix(schematics): sidenav toolbar should use default background #13282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Sep 23, 2018

it should also have a bottom border rather than elevation

Spec:
mio-design_assets_11lvr4y0v_yjj1pqoggxwfx0rius2irmu_standard-behavior-visibility-permanent

Before:
screen shot 2018-09-22 at 9 15 05 pm

After:
screen shot 2018-09-23 at 2 27 50 pm

@Splaktar Splaktar added the target: major This PR is targeted for the next major release label Sep 23, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 23, 2018
@jelbourn
Copy link
Member

Looking through the spec, it seems like the sidenav shouldn't even have a toolbar in it now. What do you think about just removing it?

@Splaktar
Copy link
Contributor Author

@jelbourn something more like this?

@jelbourn
Copy link
Member

Yeah- my interpretation there is that it's not a toolbar, just a header with the same style as the toolbar.

@Splaktar Splaktar force-pushed the alignNavSchematicWithSpec branch from 66c6122 to 84e7d52 Compare September 24, 2018 20:47
@Splaktar
Copy link
Contributor Author

I got rid of the border-bottom, but removing the mat-toolbar and making it a h2 or h3 doesn't really work without duplicating a lot of styles if we want the elements to line up properly.

screen shot 2018-09-24 at 4 47 29 pm
screen shot 2018-09-24 at 4 47 59 pm

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 25, 2018
@jelbourn jelbourn merged commit c454f7b into master Sep 25, 2018
@Splaktar Splaktar deleted the alignNavSchematicWithSpec branch September 25, 2018 21:09
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants