fix(chips): disabled state not matching specs #13272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
P2
googlebot
added
the
cla: yes
crisbeto
reviewed
Sep 23, 2018
src/lib/chips/chips.scss
Outdated
| @@ -150,6 +146,17 @@ $mat-chip-remove-size: 18px; | |||
| } | |||
| } | |||
|
|
|||
| .mat-standard-chip.mat-chip-disabled { | |||
There was a problem hiding this comment.
This can be moved up into the .mat-standard-chip styles so all the standard chip styling is in the same place.
src/lib/chips/_chips-theme.scss
Outdated
| &:focus { | ||
| @include _mat-theme-elevation(3, $theme); | ||
| &:not(.mat-chip-disabled) { | ||
| &:focus, &:active { |
There was a problem hiding this comment.
Looking at the spec again, focused chips aren't supposed to have an elevation, but rather a darker overlay:
There was a problem hiding this comment.
Yeah, I can change that while being at it. Should I also make the overlay darker if focused?
There was a problem hiding this comment.
Done. The darker overlay if focused is already added to the chips.
devversion
force-pushed
the
fix/chips-disabled-state-match-specs
branch
from
eac3dce to
2013153
Compare
crisbeto
added
pr: lgtm
action: merge
jelbourn
added
blocked
devversion
added
target: patch
jelbourn
removed
blocked
devversion
force-pushed
the
fix/chips-disabled-state-match-specs
branch
from
2013153 to
3022b8b
Compare
* Currently if chips are disabled with the spec 2018 alignment, it's not clear whether a chip is disabled or not. The chip still has a focus effect, hover effect and pointer cursor for the `mat-chip-remove`. * Also moves the `@include mat-elevation` to the theme (probably introduced before: angular#11344 has been merged)
devversion
force-pushed
the
fix/chips-disabled-state-match-specs
branch
from
3022b8b to
662abab
Compare
josephperrott
pushed a commit
that referenced
this pull request
Nov 19, 2018
* Currently if chips are disabled with the spec 2018 alignment, it's not clear whether a chip is disabled or not. The chip still has a focus effect, hover effect and pointer cursor for the `mat-chip-remove`. * Also moves the `@include mat-elevation` to the theme (probably introduced before: #11344 has been merged)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mat-chip-remove.@include mat-elevationto the theme (probably introduced before: feat(elevation): move elevation rules into theme stylesheets #11344 has been merged)