Skip to content

build: refresh package-lock file #13122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

devversion
Copy link
Member

  • Currently when updating the package.json file, we just refreshed the lock state of the given package. This refreshes the whole lock-file to reflect the package versions from package.json.
  • Fixes two RxJS type issue that appear with the currently specified RxJS version.

Marking as major because the package-lock file won't be easy to cherry-pick into patch & minor branches.

* Currently when updating the `package.json` file, we just refreshed the lock state of the given package. This refreshes the whole lock-file to reflect the package versions from `package.json`.
* Fixes two RxJS type issue that appear with the currently specified RxJS version.
@devversion devversion added pr: merge safe target: major This PR is targeted for the next major release labels Sep 14, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 14, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 14, 2018
@jelbourn jelbourn merged commit 20beff4 into angular:master Sep 14, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants