feat(ng-add): add x-prompts to install schematics #13058
Conversation
devversion
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
| @@ -19,12 +19,14 @@ | |||
| "theme": { | |||
| "enum": ["indigo-pink", "deeppurple-amber", "pink-bluegrey", "purple-green", "custom"], | |||
| "default": "indigo-pink", | |||
| "description": "The theme to apply" | |||
| "description": "The theme to apply", | |||
| "x-prompt": "What theme would you like to generate?" | |||
There was a problem hiding this comment.
How about
Enter a prebuilt theme name, or "custom" for a custom theme.
There was a problem hiding this comment.
That sounds better. Updated.
| }, | ||
| "gestures": { | ||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "Whether gesture support should be set up or not." | ||
| "description": "Whether gesture support should be set up or not.", | ||
| "x-prompt": "Would you like to set up gesture support?" |
There was a problem hiding this comment.
How about
Add HammerJs for gesture recognition?
f398bf5 to
b4f76f3
Compare
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
CircleCI flake? |
|
Not sure. There isn't really anything in this PR that affects the @nodejs//:npm execution. |
|
Just repush? (rerunning directly on circle ci is... problematic) |
devversion
force-pushed
the
feat/ng-add-x-prompts
branch
from
b4f76f3 to
ceba8db
Compare
|
@jelbourn Yeah fixed now. I was mobile yesterday and couldn't repush, so I just tried rerunning. |
|
@devversion just needs rebase |
|
Hi @devversion! This PR has merge conflicts due to recent upstream merges. |
* Recently the Angular CLI project introduced prompt support for schematics. Even though they seem to not run when using `7.0.0-beta.2` of the CLI, we should already ship the simple prompts for the `ng add` command. * Renames the `/schematics/install` folder to `/schematics/ng-add`. (this makes it consistent with the actual schematic name and other packages that ship the `ng-add` schematic (e.g. `@angular/elements`)
devversion
force-pushed
the
feat/ng-add-x-prompts
branch
from
ceba8db to
aa4eb90
Compare
|
@jelbourn Done. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
7.0.0-beta.2of the CLI, we should already ship the simple prompts for theng addcommand./schematics/installfolder to/schematics/ng-add. (this makes it consistent with the actual schematic name and other packages that ship theng-addschematic (e.g.@angular/elements)