Skip to content

docs(overlay): add note about pre-built styles #12993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 5, 2018

Adds a note about the pre-built overlay styles since we have no mention of them anywhere else in the docs.

Fixes #8717.

@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Sep 5, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner September 5, 2018 20:07
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 5, 2018
Adds a note about the pre-built overlay styles since we have not mention of them anywhere else in the docs.

Fixes angular#8717.
@crisbeto crisbeto force-pushed the 8717/overlay-prebuilt-docs branch from 09541b8 to 80e2efb Compare September 5, 2018 20:09
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 5, 2018
@jelbourn jelbourn merged commit 86be1dc into angular:master Sep 5, 2018
jelbourn pushed a commit that referenced this pull request Sep 11, 2018
Adds a note about the pre-built overlay styles since we have not mention of them anywhere else in the docs.

Fixes #8717.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why don't you write about cdk/xxx-prebuilt.css in CDK docs?
3 participants