refactor(ng-update): better check for updated constructor signatures

[devversion]

Instead of just checking the length of the constructor arguments, we now check the types of the constructor or super call. This means that we can way better report invalid signatures for constructor changes like for the MatCalendar (#9775). Just relying on the length of arguments means that order is being ignored.

This also makes maintaining the constructor signature changes easier (there are a lot of instances for V7).

NOTE: There is one downside: Right now since we cannot check whether a type is assignable to another one, things like that will result in a false report.

interface ExtendedDocument extends Document {}

new MatIconRegistry({}, {}, {} as ExtendedDocument);

But IMO since this just results in a polite message from TSLint, and we benefit a lot more for things like the MatCalendar, we should be fine having this trade-off. We can follow-up with some custom checks.

[devversion]

FYI: There will be a follow-up PR that adds some additional messages to the TSLint failure.

Even though it's not necessarily needed because we show the new signature, it's good to explain people what changed.

[devversion]

Note: Technically the type checker wouldn't be a good idea to use for the schematics because when doing an upgrade from V5 to V7, we won't have typings for V5 and V6 once ng update runs.

But since the Angular CLI always installs the desired target version, we will have the typings for that version and can just check the signatures. Since we just check and not migrate anything, it's even better just displaying the signature of the target Material version.

e.g. consider the following signatures for each version:

• V5: MatAutocomplete#constructor(String, String)
• V6: MatAutocomplete#constructor(String, String, Number)
• V7: MatAutocomplete#constructor(String, String)

In that case if someone upgrades from V5 to V7, we should not add a TSLint failure. But if someone upgrades from V5 to only V6, it will throw. Same if V6 to V7 runs.

[jelbourn]

LGTM

[jelbourn]

Add a comment here explaining what this config is for?

[devversion]

Can do. Will do that while rebasing.

[devversion]

@jelbourn Rebased.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}