Skip to content

build: fix radio e2e tests timing out #12857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

crisbeto
Copy link
Member

Fixes a timeout in the radio button e2e tests, after the new design changes got in. The tests expect there to be no ripples, but the new design introduced a permanent ripple in each button. This is along the same lines as #12699.

Fixes a timeout in the radio button e2e tests, after the new design changes got in. The tests expect there to be no ripples, but the new design introduced a permanent ripple in each button. This is along the same lines as angular#12699.
@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Aug 27, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 27, 2018
@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 27, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 6aa7727 into angular:master Aug 27, 2018
jelbourn pushed a commit that referenced this pull request Aug 29, 2018
Fixes a timeout in the radio button e2e tests, after the new design changes got in. The tests expect there to be no ripples, but the new design introduced a permanent ripple in each button. This is along the same lines as #12699.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants