refactor(schematics): css name rules interfere with element selectors #12805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
|
Hi @devversion! This PR has merge conflicts due to recent upstream merges. |
|
@devversion just needs rebase |
* Currently the `cssName` rules interfere with the element selector rules. This is not desired because it causes unexpected behavior because both rules try to update specific code parts. * Renames the `cssNames` data to `cssSelectors` because technically this rule should **only** update CSS selectors inside of string literals, stylesheets and also partly templates (inline styles). * Fixes that TypeScript sometimes doesn't report syntax failures (credits to @jelbourn)
devversion
force-pushed
the
refactor/css-names-interfere-element-selectors
branch
from
a0bf946 to
cba1ecc
Compare
|
@jelbourn Done. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cssNamerules interfere with the element selector rules. This is not desired because it causes unexpected behavior because both rules try to update specific code parts.cssNamesdata tocssSelectorsbecause technically this rule should only update CSS selectors inside of string literals, stylesheets and also partly templates (inline styles).