Skip to content

build(schematics): missing schema files in bazel npm package #12770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2018
Merged

build(schematics): missing schema files in bazel npm package #12770

merged 1 commit into from
Aug 21, 2018

Conversation

devversion
Copy link
Member

  • If some builds the npm_package of the schematics through Bazel, the schema.json files won't be available.

@devversion
build(schematics): missing schema files in bazel npm package
ccb7795 
* If some builds the `npm_package` of the schematics through Bazel, the `schema.json` files won't be available.
@devversion devversion requested a review from amcdnl as a code owner August 21, 2018 11:34
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 21, 2018
jelbourn
jelbourn approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 21, 2018
@jelbourn jelbourn merged commit 8673e40 into angular:master Aug 21, 2018
@devversion devversion deleted the buidl/schematics-schema_json_bazel branch August 21, 2018 14:42
crisbeto added a commit to crisbeto/material2 that referenced this pull request Aug 25, 2018
@crisbeto
build(schematics): missing schema files in bazel npm package (angular…
fa56d57 
…#12770)

If someone builds the `npm_package` of the schematics through Bazel, the `schema.json` files won't be available.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @jelbourn @googlebot