fix(ng-update): form-field css name incorrectly updated #12768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
* Cleans up the `class-names` and `css-names` update rules. Moves them into separate directories for a better overview (similar to the attribute selectors; grouped by data input) * Fixes that the `css-name` rules incorrectly replace `mat-form-field-placeholder-wrapper` with `mat-form-field-labeler`. This happens because we first look for `mat-form-field-placeholder` -> create the replacement -> and then check on the same content (for proper offsets and reporting) and create another replacement for `mat-form-field-placeholder-wrapper`. `mat-form-field-placeholder-wrapper` should be just updated as part of `mat-form-field-placeholder`. * Updates an incorrect Github PR link for the `$mat-font-family` removal.
devversion
force-pushed
the
fix/ng-update-form-field-css-names
branch
from
2c3604b to
db8b23c
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
css-namerules incorrectly replacesmat-form-field-placeholder-wrapperwithmat-form-field-labeler.This happens because we first look for
mat-form-field-placeholder-> create the replacement -> thencheck on the same content for
mat-form-field-placeholder-wrapper(needed for proper offsets and reporting) -> create another replacement format-form-field-placeholder-wrapper.Solution:
mat-form-field-placeholder-wrappershould be just updated as part ofmat-form-field-placeholder.Cleans up the
class-namesandcss-namesupdate rules. Moves them into separate directories for a better overview (similar to the attribute selectors; grouped by data input)Updates an incorrect Github PR link for the
$mat-font-familyremoval.