Skip to content

build: fix docs-content branch publish #12690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Currently the docs-content output will be overwritten each time a Travis job runs in another branch (e.g. master, 6.4.x, 6.x).

This is because the given branches cannot be created in the material2-docs-content repository and we always only publish to origin/master.


Scenario: We want to release a new patch version, but have no way to properly pull the docs-content data that matches the given new version. Meaning that the docs-content and the @angular/material-examples package is based on the next major version and we run into runtime exceptions due to the breaking changes.


Note: This should go into the patch branches because we want to fix the docs-content repository.

Currently the docs-content output will be overwritten each time a Travis job runs in another branch (e.g. `master`, `6.4.x`, `6.x`). This is because the given branches cannot be created in the `material2-docs-content´ repository.

This is not good because if we want to release a new patch version, we have no way to properly pull the docs-content data that matches the given new version. Meaning that the docs-content and the `@angular/material-examples` package might be already updated for the next `major` version and we run into runtime exceptions due to the breaking changes.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Aug 15, 2018
@devversion devversion requested a review from jelbourn as a code owner August 15, 2018 19:29
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 15, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 15, 2018
@mmalerba mmalerba merged commit 009f211 into angular:master Aug 15, 2018
mmalerba pushed a commit that referenced this pull request Aug 20, 2018
Currently the docs-content output will be overwritten each time a Travis job runs in another branch (e.g. `master`, `6.4.x`, `6.x`). This is because the given branches cannot be created in the `material2-docs-content´ repository.

This is not good because if we want to release a new patch version, we have no way to properly pull the docs-content data that matches the given new version. Meaning that the docs-content and the `@angular/material-examples` package might be already updated for the next `major` version and we run into runtime exceptions due to the breaking changes.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants