Skip to content

feat(overlay): add option to automatically dispose on navigation #12592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2018
Merged

feat(overlay): add option to automatically dispose on navigation #12592

merged 1 commit into from
Sep 25, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 8, 2018

Adds the opt-in disposeOnNavigation option which will dispose of an overlay when the user goes back/forward in history. This is something that we had in MatDialog and MatBottomSheet already, but it's a common-enough case, especially for global overlays, that it makes sense to have it in the CDK.

Fixes #12544.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Aug 8, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner August 8, 2018 20:39
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 8, 2018
@crisbeto crisbeto force-pushed the 12544/overlay-dispose-on-navigation branch from 8d1453f to 8a4ab66 Compare August 9, 2018 17:21
jelbourn
jelbourn approved these changes Aug 9, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 9, 2018
@ngbot
Copy link

ngbot bot commented Aug 9, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn
Copy link
Member

jelbourn commented Aug 22, 2018 •
edited
Loading

@crisbeto seeing presubmit test failures for this one like:

Error: No base href set. Please provide a value for the APP_BASE_HREF token or add a base element to the document.

@crisbeto
Copy link
Member Author

That sounds weird, because routing won't work without the base tag AFAIK. Also we have a few other components that are using Location and we haven't had issues until now.

@ngbot
Copy link

ngbot bot commented Sep 14, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

2 similar comments
@ngbot
Copy link

ngbot bot commented Sep 14, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@ngbot
Copy link

ngbot bot commented Sep 14, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto crisbeto force-pushed the 12544/overlay-dispose-on-navigation branch from 8a4ab66 to 6a80e69 Compare September 21, 2018 20:37
@crisbeto
feat(overlay): add option to automatically dispose on navigation
346d455 
Adds the opt-in `disposeOnNavigation` option which will dispose of an overlay when the user goes back/forward in history. This is something that we had in `MatDialog` and `MatBottomSheet` already, but it's a common-enough case, especially for global overlays, that it makes sense to have it in the CDK.

Fixes angular#12544.
@crisbeto crisbeto force-pushed the 12544/overlay-dispose-on-navigation branch from 6a80e69 to 346d455 Compare September 22, 2018 14:51
@jelbourn jelbourn merged commit d48b1ba into angular:master Sep 25, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@crisbeto @roboshoes
feat(overlay): add option to automatically dispose on navigation (ang…
e8f4fa0 
…ular#12592)

Adds the opt-in `disposeOnNavigation` option which will dispose of an overlay when the user goes back/forward in history. This is something that we had in `MatDialog` and `MatBottomSheet` already, but it's a common-enough case, especially for global overlays, that it makes sense to have it in the CDK.

Fixes angular#12544.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CDK: Add config to close the overlay when browser back button is pressed
3 participants
@crisbeto @jelbourn @googlebot