Skip to content

fix(datepicker): input not picking up changes if datepicker is assigned after init #12546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2018
Merged

fix(datepicker): input not picking up changes if datepicker is assigned after init #12546

merged 1 commit into from
Aug 7, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 6, 2018

  • Fixes the datepicker input not reacting to changes in the datepicker's value, if it's assigned after ngAfterContentInit has passed.
  • Fixes an error that is thrown when pressing ALT + DOWN_ARROW if the input doesn't have a datepicker yet.
  • Adds a test for the ALT + DOWN_ARROW shortcut.

@crisbeto
fix(datepicker): input not picking up changes if datepicker is assign…
c3f352a 
…ed after init

* Fixes the datepicker input not reacting to changes in the datepicker's value, if it's assigned after `ngAfterContentInit` has passed.
* Fixes an error that is thrown when pressing ALT + DOWN_ARROW if the input doesn't have a datepicker yet.
* Adds a test for the ALT + DOWN_ARROW shortcut.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Aug 6, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner August 6, 2018 04:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 6, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 6, 2018
@josephperrott josephperrott merged commit 3299628 into angular:master Aug 7, 2018
josephperrott pushed a commit that referenced this pull request Aug 7, 2018
@crisbeto @josephperrott
fix(datepicker): input not picking up changes if datepicker is assign…
788e563 
…ed after init (#12546)
josephperrott pushed a commit that referenced this pull request Aug 7, 2018
@crisbeto @josephperrott
fix(datepicker): input not picking up changes if datepicker is assign…
d10a6c4 
…ed after init (#12546)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @mmalerba @googlebot @josephperrott