Skip to content

build: add tslint rule to enforce import spacing #12536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 5, 2018

This is something that comes up on a semi-regular basis during review. Ensures that imports don't have spaces after the opening brace and before the closing one.

This is something that comes up on a semi-regular basis during review. Ensures that imports don't have spaces after the opening brace and before the closing one.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 5, 2018
@crisbeto crisbeto changed the title build: add tslint rule enforce import spacing build: add tslint rule to enforce import spacing Aug 5, 2018
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I never really run into such PRs, but should be still good to get in.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 5, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott merged commit 9692333 into angular:master Aug 7, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants